Skip to content

Conversation

yyassi-heartex
Copy link
Contributor

This pull request improves the handling of the Agreement filter dropdown in the data manager table. The main focus is to ensure that the dropdown closes automatically after saving changes and to provide a way for the header cell to trigger closing the dropdown.

Dropdown behavior improvements:

  • Added an onClose callback to AgreementSelected.HeaderCell, allowing the header cell to close the dropdown when needed. [1] [2]
  • Updated the onSave handler in TableHead.jsx to automatically close the dropdown after saving agreement filters.

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner October 2, 2025 18:39
@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 081d082
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68f241bc2f3f0200084e555c

@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 081d082
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68f241bc8d6cd00008eac1d1
😎 Deploy Preview https://deploy-preview-8575--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Oct 2, 2025
@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 081d082
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68f241bcdb11e100073b81b4

@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 081d082
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68f241bcc4603e0008576668
😎 Deploy Preview https://deploy-preview-8575--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.13%. Comparing base (7f20111) to head (081d082).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8575       +/-   ##
============================================
+ Coverage    36.48%   67.13%   +30.64%     
============================================
  Files          719      792       +73     
  Lines        54681    60395     +5714     
  Branches      9024    10290     +1266     
============================================
+ Hits         19953    40544    +20591     
+ Misses       34725    19848    -14877     
  Partials         3        3               
Flag Coverage Δ
lsf-e2e 54.38% <ø> (?)
lsf-integration 50.82% <ø> (?)
lsf-unit 8.40% <ø> (ø)
pytests 79.74% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner October 2, 2025 19:19
@AndrejOros
Copy link
Contributor

AndrejOros commented Oct 13, 2025

/fm sync

Workflow run

@AndrejOros
Copy link
Contributor

AndrejOros commented Oct 16, 2025

/git merge

Workflow run
Successfully merged: 3 files changed, 31 insertions(+), 4 deletions(-)

@AndrejOros
Copy link
Contributor

AndrejOros commented Oct 17, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/lib/modal/index.ts

@robot-ci-heartex robot-ci-heartex merged commit b791ccc into develop Oct 17, 2025
53 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-750/updated-ui branch October 17, 2025 17:53
nass600 pushed a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants